feat(server): add integrity attribute to JSX elements#1032
Open
leovalette wants to merge 1 commit intogregberge:mainfrom
Open
feat(server): add integrity attribute to JSX elements#1032leovalette wants to merge 1 commit intogregberge:mainfrom
leovalette wants to merge 1 commit intogregberge:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation:
While migrating our App to streaming SSR using
renderToPipeableStream, we identified a limitation in@loadable/server. Currently, there is a discrepancy between the two ways to retrieve asset tags:getScriptTags(),getStyleTags()) → Includeintegrityattributes ✅getScriptElements(),getStyleElements()) → Do not includeintegrityattributes ❌This PR resolves this issue by ensuring that the
integrityproperty from webpack stats is correctly passed to the generated JSX elements. This allows for Subresource Integrity (SRI) checks to be maintained when using the JSX API.Changes include:
assetToScriptElement,assetToStyleElement, andassetToLinkElementinChunkExtractor.jsto include theintegrityprop if available.Test plan
New unit tests have been added to
packages/server/src/ChunkExtractor.test.jsto cover this feature.